Skip to content

adding new ways to say varchar #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2023
Merged

adding new ways to say varchar #2000

merged 4 commits into from
Sep 13, 2023

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Sep 12, 2023

This PR makes to so the engine recognizes more ways to specify that a column is of type VARCHAR
Companion PR: dolthub/vitess#270

Fixes dolthub/dolt#6650

Copy link
Contributor

@nicktobey nicktobey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests? Otherwise, looks good.

@jycor jycor merged commit 0324aff into main Sep 13, 2023
@Hydrocharged Hydrocharged deleted the james/varchar branch February 7, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support all the different ways to specify character types
2 participants