Fixes for subquery indexing/correlation tracking #1994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Sep 8, 2023
| @@ -92,9 +93,13 @@ func (s *Scope) NewScope(node sql.Node) *Scope { | |||
|
|
|||
| // NewScopeFromSubqueryExpression returns a new subscope created from a subquery expression contained by the specified | |||
| // node. | |||
| func (s *Scope) NewScopeFromSubqueryExpression(node sql.Node) *Scope { | |||
| func (s *Scope) NewScopeFromSubqueryExpression(node sql.Node, corr sql.ColSet) *Scope { | |||
There was a problem hiding this comment.
Would be helpful to update the method doc to mention the corr parameter and explain what it means here. It's probably painfully obvious to you of course, but a little documentation there would help other people from having to reverse engineer it when they see this code for the first time.
There was a problem hiding this comment.
added some attribute docs for what it means, and doc comment here to indicate why it needs to be explicit for subquery expressions
Co-authored-by: Jason Fulghum <[email protected]>
max-hoffman
added a commit
that referenced
this pull request
Sep 8, 2023
* fixidx refactors, remove from pushdown * [ga-format-pr] Run ./format_repo.sh to fix formatting * Fixes for subquery indexing/correlation tracking (#1994) * Fixes for subquery indexing/correlation tracking * Update sql/planbuilder/scope.go Co-authored-by: Jason Fulghum <[email protected]> * jason's comments --------- Co-authored-by: Jason Fulghum <[email protected]> --------- Co-authored-by: max-hoffman <[email protected]> Co-authored-by: Jason Fulghum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed a place where we were using getField indexes to do a correlation check. This adds the changes necessary to replace that check with one that uses a subquery's tracked correlation column set. This also adds an expression id column to GetField expression that preserves the id tracking information between iterative passes of the analyzer. It would probably be preferable to avoid all cases where we unnecessarily re-run rules, but this is more near at hand.