Skip to content

Conversation

macneale4
Copy link
Contributor

@macneale4 macneale4 commented Aug 31, 2023

Add JSON Value mutation operations and tests. These changes do not alter the operation of dolt in anyway yet - that will come in a second PR which updates the JSON_SET procedure, and adds support for the JSON_REPLACE, JSON_INSERT, and JSON_REMOVE procedures at the same time. This is laying the foundation for that work.

@macneale4 macneale4 force-pushed the macneale4/json_mutation branch from cf55b8a to 08748b9 Compare August 31, 2023 21:45
@macneale4 macneale4 force-pushed the macneale4/json_mutation branch from 8c97987 to 3a5027f Compare August 31, 2023 22:50
@macneale4 macneale4 marked this pull request as ready for review August 31, 2023 22:51
@macneale4 macneale4 requested a review from fulghum August 31, 2023 22:51
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code look correct and the tests look beautiful!

Just some really small comments. Biggest one was that the doc arg in the new functions in json_value.go seemed like it could be simplified a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants