Logging: Don't overwrite LDEBUG level in Release builds #13939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentomologist
force-pushed
the
logging_avoid_overwriting_debug_verbosity_in_release_builds
branch
from
4750daa to
bccd382
Compare
|
I've fixed the build on Android, but I'm not familiar enough with the Android settings code to be sure the change is working as intended there. If someone could test that when they have a chance that'd be great. |
Pokechu22
approved these changes
Sep 12, 2025
JosJuice
reviewed
Sep 15, 2025
Preserve the configured logging verbosity unless the user actually changes it, rather than capping it to LINFO on release builds. Rename LogManager::m_level to m_effective_level and distinguish between the config and effective level in various function/variable names.
Dentomologist
force-pushed
the
logging_avoid_overwriting_debug_verbosity_in_release_builds
branch
from
bccd382 to
3fea0a4
Compare
|
If someone were to set LOGGER_VERBOSITY without going through SetConfigLogLevel (or manually calling SetEffectiveLogLevel afterwards), m_effective_level wouldn't get updated, right? This scenario can be triggered using game INIs. You could solve this either using a config changed callback, or by having GetEffectiveLogLevel check Config::GetConfigVersion and call SetEffectiveLogLevel if the config version has changed since the last SetEffectiveLogLevel call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve the configured logging level unless the user actually changes it, rather than capping
LDEBUGtoLINFOon release builds (which then persisted when going back to a debug build).Rename
LogManager::m_leveltom_effective_leveland distinguish between the config and effective level in various function/variable names.