Skip to content

Conversation

Tilka
Copy link
Member

@Tilka Tilka commented Aug 30, 2025

MaxAnisotropy = 0 is no longer the safest setting because it forces 1x
even if the game asks for more.

ForceFiltering was replaced by ForceTextureFiltering in
afe9d5b. The one remaining occurrence
was merged later.

ForceTextureFiltering is an int option and shouldn't be set to False.

Just Dance 3, Just Dance: Best of, and Just Dance: Greatest Hits look
fine on AMD GPUs without manual texture sampling. On Nvidia GPUs they
have a single stripe that I think doesn't warrant forcing manual texture
sampling for everyone.

The NES games I tried worked fine with anisotropic filtering, it just
doesn't do anything.

Various games don't actually have any issue with anisotropic filtering
as long as it's not forced. The only game I could find that actually
requires the default aniso setting is Spider-Man: Shattered Dimensions.

Boogie SuperStar works fine with any texture filtering setting.

@Tilka Tilka force-pushed the tex_filter_settings branch from 752a38c to 43b1e4a Compare August 30, 2025 01:54
`MaxAnisotropy = 0` is no longer the safest setting because it forces 1x
even if the game asks for more.

`ForceFiltering` was replaced by `ForceTextureFiltering` in
afe9d5b. The one remaining occurrence
was merged later.

`ForceTextureFiltering` is an int option and shouldn't be set to False.

Just Dance 3, Just Dance: Best of, and Just Dance: Greatest Hits look
fine on AMD GPUs without manual texture sampling. On Nvidia GPUs they
have a single stripe that I think doesn't warrant forcing manual texture
sampling for everyone.

The NES games I tried worked fine with anisotropic filtering, it just
doesn't do anything.

Various games don't actually have any issue with anisotropic filtering
as long as it's not forced. The only game I could find that actually
requires the default aniso setting is Spider-Man: Shattered Dimensions.

Boogie SuperStar works fine with any texture filtering setting.
@Tilka Tilka force-pushed the tex_filter_settings branch from 43b1e4a to 9396f0f Compare August 31, 2025 00:03
Copy link
Member

@mbc07 mbc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual Texture Sampling has a performance impact but unless you're on a really, really low end device, the impact on the affected Just Dance games should be negligible, since there's not much going on during actual game play (essentially the coach video and the HUD).

With that said, and considering the texture sampling bug affects all NVIDIA GPUs, some Intel and some Mali GPUs, which consists of a huge chunk of our userbase, and that Dolphin currently can't apply INI settings selectively based on the GPU the user has, Manual Texture Sampling should be kept for Just Dance 3 (SDJ.ini), Just Dance Greatest Hits (SJHE41.ini) and Just Dance: Best Of (SJTP41.ini).

Additionally, Just Dance 4 (SJX.ini) got its INI deleted, but it should be reinstated and updated to have ForceTextureFiltering = 0 like the earlier Just Dance titles: although all on-disc songs switched to a different video format that has no issues with forced texture filtering, the startup videos and initial loading screen, as well as some of the DLC songs, still uses the old format from Just Dance 3 and earlier, which gets completely broken if texture filtering is forcibly enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants