Skip to content

Conversation

morozov
Copy link
Member

@morozov morozov commented May 8, 2022

In order to run the builds on different DBAL versions, a custom definition of the static analysis workflow is used (it's mostly a copy-paste from the DBAL).

Relevant changes from DBAL 4.0.x:

TODO:

@morozov morozov added this to the 3.0.0 milestone May 8, 2022
@morozov morozov marked this pull request as ready for review May 8, 2022 19:29
@morozov morozov requested review from greg0ire and derrabus May 8, 2022 19:30
@morozov morozov changed the title Run Psalm with DBAL 4@dev Run static analysis with DBAL 4@dev May 8, 2022
@morozov morozov merged commit a711fad into doctrine:3.0.x May 8, 2022
@morozov morozov deleted the dbal-4@dev-static-analysis branch May 8, 2022 19:49
@ondrejmirtes
Copy link
Contributor

Hi, are you sure you haven't made a mistake here with assert(is_numeric($sql))? I'm seeing bug related to this change: #11240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants