Remove non-API DriverConnectionMock methods #9709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
requested review from
derrabus and
greg0ire
and removed request for
derrabus
derrabus
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #9707, this patch reworks the tests that use hard-coded
DriverMockin favor of a PHPUnit-generated mock and removes the no longer used methods fromDriverMock.Note that the reworked version of the test uses the internal
Cache\ArrayResultclass from the DBAL. While it's not ideal, it's acceptable. If this class changes upstream, it can be easily copy-pasted to the test suite.I'll continue reworking tests only for 3.0.x since mocking both the DBAL 2.x and 3.x APIs in ORM 2.x tests requires extra effort.