Document exception-splitting-related BC-breaks #7196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
previously approved these changes
Apr 13, 2018
|
Actually, how about we stop using "create" and use "new" instead? throw Exception\MismatchedEventManager::new() |
|
On one hand, that will probably give weird syntactic coloration like it does on 3v4l, OTOH, it's nice because people might be less confused about what it does, and on the third hand if you're an 👽 , are they really confused about what |
greg0ire
force-pushed
the
document_exception_split_bc_breaks
branch
from
3e1d2f8 to
7ef5f70
Compare
derrabus
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7194
Should be modified if #7195 is not mergeddone