-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Convert PHPUnit annotations to attributes #10559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By all means, we're open to such PRs. Can you take a look at phpcs? |
Looks good so far. One thing: Doesn't PHPUnit 10 have an attribute equivalent for
PHPCS fails because a test has been commented out and because the following test does not have a PHPDoc block anymore, it assumes that the commented-put test is a badly formatted PHPDoc block. Here's my take at fixing the issue on 2.14.x by skipping the test instead of commenting it out: #10560. Alternatively, we could just delete that test. |
It does, Rector missed it or wasn't able. I will have another look 👍 |
The PHPCS failure should be gone after a rebase. |
You mean one failure out of three I think. @chr-hertel please do check it works before force-pushing. |
@@ -25,8 +25,10 @@ | |||
use Doctrine\Tests\Models\Company\CompanyManager; | |||
use Doctrine\Tests\Models\Company\CompanyOrganization; | |||
use Doctrine\Tests\Models\Company\CompanyPerson; | |||
use Doctrine\Tests\ORM\Functional\Ticket\MyEntity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reverted
This should help: #10563 |
Ah, I missed the other test. Thanks, @greg0ire. |
Browsing through all of the But we can remove those in a follow-up, no need to block a merge because of that. Great work. 👍🏻 |
Rector did the work and I cleaned up. Not sure if you're open for this kind of PRs, but was my sunday meditation anyways :)