Skip to content

Use spl_object_id() instead of spl_object_hash() #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

Use spl_object_id() instead of spl_object_hash() #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/EventManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace Doctrine\Common;

use function spl_object_hash;
use function spl_object_id;

/**
* The EventManager is the central point of Doctrine's event listener system.
Expand Down Expand Up @@ -81,12 +81,12 @@ public function hasListeners(string $event): bool
public function addEventListener(string|array $events, object $listener): void
{
// Picks the hash code related to that listener
$hash = spl_object_hash($listener);
$oid = spl_object_id($listener);

foreach ((array) $events as $event) {
// Overrides listener if a previous one was associated already
// Prevents duplicate listeners on same event (same instance only)
$this->listeners[$event][$hash] = $listener;
$this->listeners[$event][$oid] = $listener;
}
}

Expand All @@ -98,10 +98,10 @@ public function addEventListener(string|array $events, object $listener): void
public function removeEventListener(string|array $events, object $listener): void
{
// Picks the hash code related to that listener
$hash = spl_object_hash($listener);
$oid = spl_object_id($listener);

foreach ((array) $events as $event) {
unset($this->listeners[$event][$hash]);
unset($this->listeners[$event][$oid]);
}
}

Expand Down