Make the class parameter mandatory for references #464
Conversation
| @@ -96,7 +98,7 @@ public function testReferenceReconstruction(): void | |||
|
|
|||
| $roleFixture->load($em); | |||
| // first test against managed state | |||
| $ref = $referenceRepository->getReference('admin-role'); | |||
| $ref = $referenceRepository->getReference('admin-role', Role::class); | |||
There was a problem hiding this comment.
Should we have made these adjustments to the tests on 1.x already?
There was a problem hiding this comment.
Yes and no, depends on the test strategy.
The "old way" to call getReference must be tested on 1.x too.
On 1.x test should have been duplicated with
- The old way, working but triggering deprecation, and a
@group legacy - The new way working without deprecation.
Seems like no test were added/duplicated in #409, so only the old way were tested. Now on 2.x tests are updated.
There was a problem hiding this comment.
So, we're missing coverage for the non-deprecated way in 1.x currently? We should fix that first, I suppose.
|
Please remember to update the UPGRADE.md file. |
derrabus
changed the title
|
This change is not documented at https://symfony.com/bundles/DoctrineFixturesBundle/current/index.html |
DoctrineFixtureBundle only support data-fixture v2 since few hours. |
|
Please open an issue (or a PR) on the bundle's repository. |
This PR was squashed before being merged into the main branch. Discussion ---------- Update the data fixtures The class parameter is now mandatory for references. Fixes exception when running `bin/console doctrine:fixtures:load`: ``` [ArgumentCountError] Too few arguments to function Doctrine\Common\DataFixtures\AbstractFixture::getReference(), 1 passed in /workspace/project/src/DataFi xtures/AppFixtures.php on line 143 and exactly 2 expected ``` Related to: doctrine/data-fixtures#464 Commits ------- 0ad830b Update the data fixtures
No description provided.