Skip to content

Conversation

@franmomu
Copy link
Contributor

@franmomu franmomu commented Jan 6, 2023

Use the latest doctrine/coding-standard version (it supports "php": "^7.2 || ^8.0")

@franmomu franmomu added the Task label Jan 6, 2023
@franmomu franmomu added this to the 4.5.3 milestone Jan 6, 2023
@IonBazan
Copy link
Member

IonBazan commented Jan 6, 2023

@franmomu please rebase - there is a conflict after I merged #755

@franmomu
Copy link
Contributor Author

franmomu commented Jan 6, 2023

I have to check why it fails 😕

@franmomu
Copy link
Contributor Author

franmomu commented Jan 6, 2023

I guess it's because in:

https://github.com/symfony/symfony/blob/2f62c4a7951ed05e722638beb3dcdea7c650a3a2/src/Symfony/Bridge/Doctrine/DependencyInjection/AbstractDoctrineExtension.php#L320-L326

it doesn't match with /** @Document **/, I guess there should be a way to not modify these annotation for now.

@IonBazan
Copy link
Member

IonBazan commented Jan 6, 2023

Ouch, yes. I think you can add all test fixtures to ignore the coding standard or at least that particular rule.

@franmomu franmomu force-pushed the cs11 branch 4 times, most recently from 1ead1dc to ba30186 Compare January 6, 2023 12:23
Copy link
Member

@IonBazan IonBazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@IonBazan IonBazan merged commit acf2e84 into doctrine:4.5.x Jan 7, 2023
@IonBazan
Copy link
Member

IonBazan commented Jan 7, 2023

Thanks @franmomu!

@franmomu franmomu deleted the cs11 branch January 7, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants