warning: this can be `std::io::Error::other(_)`
  --> src/util/pass.rs:42:5
   |
42 |     io::Error::new(io::ErrorKind::Other, msg)
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
help: use `std::io::Error::other`
   |
42 -     io::Error::new(io::ErrorKind::Other, msg)
42 +     io::Error::other(msg)
   |

warning: this expression borrows a value the compiler would automatically borrow
  --> src/util/pass.rs:22:8
   |
22 |     Ok((&line[len..]).trim().into())
   |        ^^^^^^^^^^^^^^ help: change this to: `line[len..]`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: the borrowed expression implements the required traits
  --> src/util/digest.rs:29:20
   |
29 |     Ok(hex::encode(&sh.finalize()))
   |                    ^^^^^^^^^^^^^^ help: change this to: `sh.finalize()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this can be `std::io::Error::other(_)`
  --> src/util/digest.rs:22:34
   |
22 |             Err(_) => return Err(io::Error::new(io::ErrorKind::Other, "Could not read file")),
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
   = note: `#[warn(clippy::io_other_error)]` on by default
help: use `std::io::Error::other`
   |
22 -             Err(_) => return Err(io::Error::new(io::ErrorKind::Other, "Could not read file")),
22 +             Err(_) => return Err(io::Error::other("Could not read file")),
   |

warning: the borrowed expression implements the required traits
   --> src/http/session.rs:197:43
    |
197 |         let cnt = std::fs::read_to_string(&path).context(ReadSessionFileSnafu { path })?;
    |                                           ^^^^^ help: change this to: `path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/config.rs:210:24
    |
210 |         std::fs::write(&file, &c).map_err(|e| ConfigError::CreateDefault {
    |                        ^^^^^ help: change this to: `file`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/cli/opts.rs:342:46
    |
342 |                 let np = Self::read_name_val(&basic_file)?;
    |                                              ^^^^^^^^^^^ help: change this to: `basic_file`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/cli/opts.rs:337:46
    |
337 |                 let np = Self::read_name_val(&header_file)?;
    |                                              ^^^^^^^^^^^^ help: change this to: `header_file`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

warning: the following explicit lifetimes could be elided: 'a
  --> src/cli/cmd.rs:52:13
   |
52 |     fn exec<'a>(&self, args: &'a Context) -> Result<(), Self::CmdError>;
   |             ^^                ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
52 -     fn exec<'a>(&self, args: &'a Context) -> Result<(), Self::CmdError>;
52 +     fn exec(&self, args: &Context) -> Result<(), Self::CmdError>;
   |

warning: accessing first element with `ctx.cfg.pdf_viewer.get(0)`
   --> src/cli/cmd/view.rs:102:25
    |
102 |             let tool = &ctx.cfg.pdf_viewer.get(0).ok_or(Error::NoPdfViewer)?;
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ctx.cfg.pdf_viewer.first()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
    = note: `#[warn(clippy::get_first)]` on by default

warning: the borrowed expression implements the required traits
   --> src/cli/cmd/export.rs:286:62
    |
286 |     let rel_link_target = pathdiff::diff_paths(&link_target, &link_name_path).unwrap();
    |                                                              ^^^^^^^^^^^^^^^ help: change this to: `link_name_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/cli/cmd/export.rs:286:48
    |
286 |     let rel_link_target = pathdiff::diff_paths(&link_target, &link_name_path).unwrap();
    |                                                ^^^^^^^^^^^^ help: change this to: `link_target`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/cli/cmd/export.rs:279:33
    |
279 |         std::fs::create_dir_all(&link_name_path).context(CreateFileSnafu)?;
    |                                 ^^^^^^^^^^^^^^^ help: change this to: `link_name_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: the borrowed expression implements the required traits
   --> src/cli/cmd/export.rs:230:33
    |
230 |         std::fs::create_dir_all(&item_dir).context(CreateFileSnafu)?;
    |                                 ^^^^^^^^^ help: change this to: `item_dir`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

warning: this `impl` can be derived
  --> src/cli/cmd/export.rs:20:1
   |
20 | / impl Default for LinkNaming {
21 | |     fn default() -> Self {
22 | |         LinkNaming::Id
23 | |     }
24 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
   = note: `#[warn(clippy::derivable_impls)]` on by default
help: replace the manual implementation with a derive attribute and mark the default variant
   |
14 + #[derive(Default)]
15 ~ pub enum LinkNaming {
16 |     /// Name links to items after the items' id.
17 ~     #[default]
18 ~     Id,
   |

warning: the borrowed expression implements the required traits
   --> src/cli/cmd/download.rs:142:53
    |
142 | ...                   std::fs::create_dir_all(&parent).context(CreateFileSnafu)?;
    |                                               ^^^^^^^ help: change this to: `parent`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: you are explicitly cloning with `.map()`
   --> src/cli/cmd/admin.rs:110:18
    |
110 |       let secret = opts
    |  __________________^
111 | |         .admin_secret
112 | |         .as_ref()
113 | |         .or(ctx.cfg.admin_secret.as_ref())
114 | |         .map(String::clone);
    | |___________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
    = note: `#[warn(clippy::map_clone)]` on by default
help: consider calling the dedicated `cloned` method
    |
110 ~     let secret = opts
111 +         .admin_secret
112 +         .as_ref()
113 ~         .or(ctx.cfg.admin_secret.as_ref()).cloned();
    |

warning: bound is defined in more than one place
   --> src/http.rs:988:20
    |
988 |     pub fn copy_to<W: ?Sized>(&mut self, w: &mut W) -> Result<u64, Error>
    |                    ^
989 |     where
990 |         W: Write,
    |         ^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
    = note: `#[warn(clippy::multiple_bound_locations)]` on by default

warning: empty line after doc comment
   --> src/cli/cmd/upload.rs:413:1
    |
413 | / /// Helper types
414 | |
    | |_^
415 |   mod matching {
    |   ------------ the comment documents this module
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
    = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
    = help: if the empty line is unintentional, remove it