nat: ParsePortSpec: validate port before proto #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit f388222 made an optimization to handle validating the proto before parsing port-numbers, but as a result changed the error returned if the port was missing. This patch moves the check for empty container ports to the start to keep the old behavior. The error-message(s) can probably be improved a bit, but this keeps the existing output. Signed-off-by: Sebastiaan van Stijn <[email protected]>
austinvazquez
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
commit f388222 made an optimization to handle validating the proto before parsing port-numbers, but as a result changed the error returned if the port was missing.
This patch moves the check for empty container ports to the start to keep the old behavior. The error-message(s) can probably be improved a bit, but this keeps the existing output.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)