Skip to content

e2e/global: TestPromptExitCode: check for trailing newline #6170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

thaJeztah
Copy link
Member

Make the test slightly more permissive; we're looking for a trailing newline, not necessarily an empty line.

- A picture of a cute animal (not mandatory but encouraged)

Make the test slightly more permissive; we're looking for a trailing
newline, not necessarily an empty line.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the e2e_newline_check branch from 73c56e4 to 0c5e258 Compare July 9, 2025 11:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@vvoland vvoland merged commit 578ccf6 into docker:master Jul 9, 2025
102 of 106 checks passed
@thaJeztah thaJeztah deleted the e2e_newline_check branch July 9, 2025 17:22
@thaJeztah thaJeztah added this to the 29.0.0 milestone Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants