Skip to content

Allow absolute path in credential store/helpers #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow absolute path in credential store/helpers #6104

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
80174c1
Allow absolute path in credential store/helpers
hamnis May 22, 2025
e5ff2f8
Update cli/config/credentials/native_store.go
hamnis May 25, 2025
790983c
Merge branch 'docker:master' into allow-credential-full-path
hamnis Jun 19, 2025
b198fa4
changes after review
hamnis Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion cli/config/credentials/native_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import (
"github.com/docker/cli/cli/config/types"
"github.com/docker/docker-credential-helpers/client"
"github.com/docker/docker-credential-helpers/credentials"
"path/filepath"
)

const (
Expand All @@ -22,7 +23,12 @@ type nativeStore struct {
// NewNativeStore creates a new native store that
// uses a remote helper program to manage credentials.
func NewNativeStore(file store, helperSuffix string) Store {
name := remoteCredentialsPrefix + helperSuffix
var name string
if filepath.IsAbs(helperSuffix) {
name = helperSuffix
} else {
name = remoteCredentialsPrefix + helperSuffix
}
return &nativeStore{
programFunc: client.NewShellProgramFunc(name),
fileStore: NewFileStore(file),
Expand Down