-
Notifications
You must be signed in to change notification settings - Fork 18
Closed
Labels
Description
Hey there! Wanted to file an issue as a heads up that in Node.js v13 there has been a change that alters the default timeout option.
It has been changed from 2 minutes to 0 (which for the HTTP module itself means there will not be a timeout by default).
Your code is using that default timeout, and so when running under Node.js v13 the value will be 0 instead of 120000:
Line 23 in 25df8b9
| Dnsimple.DEFAULT_TIMEOUT = require('http').createServer().timeout; |
I opened a PR to hardcode the value to what it is under all previous Node.js versions (the value has not previously changed since it's introduction in Node.js v0.9.12)