Add cascade delete to PortalPermissions table

[DanielBolef]

Fixes #6434

Summary

Add cascade delete to PortalPermissions table

[valadas]

I was not able to reproduce the initial issue though, I created a child portal and a role with a user and was able to delete the portal just fine using the UI. Is there more to know about how to reproduce this issue ?

[bdukes]

This is about portal permissions, which were added in 9.11 via #5103. There was not a UI added to manage these yet, so you need to add them via SQL. @DanielBolef do you happen to have an example SQL query to add a permission?

[DanielBolef]

Yeah, this should do it:

DECLARE @TopLevelPagePermissionId INT

SELECT @TopLevelPagePermissionId = PermissionId FROM Permission
WHERE PermissionKey = 'ADDTOPLEVELPAGE'

INSERT INTO PortalPermission (PortalId, PermissionId, AllowAccess, RoleID, UserID)
VALUES (<PortalID to be deleted>, @TopLevelPagePermissionId, 1, <RoleID on Portal to be deleted>, NULL)

That works for the real case I was encountering, but the same issue exists for User based Portal Permissions.

DECLARE @TopLevelPagePermissionId INT

SELECT @TopLevelPagePermissionId = PermissionId FROM Permission
WHERE PermissionKey = 'ADDTOPLEVELPAGE'

INSERT INTO PortalPermission (PortalId, PermissionId, AllowAccess, RoleID, UserID)
VALUES (<PortalID to be deleted>, @TopLevelPagePermissionId, 1, NULL, <UserID on Portal to be deleted>)

In my testing while creating the above SQL, I found that the bug still exists when Users have Portal Permissions on the Portal to be deleted. This is due to the fact that Users are not deleted (I think, only UserPortals are deleted?) when a Portal is deleted, so no cascade path exists to clean up the Portal Permission. I tried adding a cascade delete for the PortalId as well, but I get a may cause cycles or multiple cascade paths conflict between the cascade path for Roles and Portals. Not sure how to resolve this.

[donker]

LGTM