We no need to add vertex if it exists #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was just about to open a PR for this exact issue and am bummed I didn't think to check sooner! I've been convinced that all of the layout algorithms in igraph are garbage because it seems like no matter what I did to my DrawIO diagram they never looked good. As another user of this library I would love to see this PR merged. |
|
Hello, was trying to reproduce the problem using from_dict method, but no luck, not seeing nodes added twice. N2G attempts to deduplicate nodes/links when they are loaded into the diagram, by the time igraph layout method called, there are should be no duplicate nodes or links present, so, what are you doing to reproduce the problem? @lautriv @3xh4l3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have already added vertex earlier, no need to add it again. Moreover it breaks drawio graph.
Before
After
