Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

szha
Copy link
Member

@szha szha commented Oct 10, 2019

Description

update installation guide by adopting the selectors from CV

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • update installation guide with selectors

cc @dmlc/gluon-nlp-team

@szha szha requested a review from a team as a code owner October 10, 2019 06:47
@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #966 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          67       67           
  Lines        6371     6371           
=======================================
  Hits         5726     5726           
  Misses        645      645

@szha szha force-pushed the install_page branch 3 times, most recently from 4da0450 to 9dba749 Compare October 11, 2019 21:35
@mli
Copy link
Member

mli commented Oct 11, 2019

Job PR-966/6 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-966/6/index.html

@leezu
Copy link
Contributor

leezu commented Oct 12, 2019

Thanks @szha

Screenshot from 2019-10-11 17-44-47

How about left-aligning the buttons?

The claim that Python 2 is supported is wrong.

@mli
Copy link
Member

mli commented Oct 15, 2019

Job PR-966/7 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-966/7/index.html

@mli
Copy link
Member

mli commented Oct 21, 2019

Job PR-966/9 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-966/9/index.html

@mli
Copy link
Member

mli commented Oct 22, 2019

Job PR-966/10 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-966/10/index.html

@sxjscience sxjscience merged commit 420719e into dmlc:master Oct 22, 2019
@szha szha deleted the install_page branch October 22, 2019 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants