Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Oct 3, 2019

Description

See #944. CPU integration tests were previously not executed.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

cc @dmlc/gluon-nlp-team

@leezu leezu requested a review from a team as a code owner October 3, 2019 18:18
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #957 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   90.13%   90.35%   +0.21%     
==========================================
  Files          67       67              
  Lines        6438     6438              
==========================================
+ Hits         5803     5817      +14     
+ Misses        635      621      -14
Impacted Files Coverage Δ
src/gluonnlp/utils/files.py 49.01% <0%> (+3.92%) ⬆️
src/gluonnlp/model/bert.py 90.26% <0%> (+5.3%) ⬆️

@leezu leezu force-pushed the integrationtestscpu branch from e510971 to 1af4076 Compare October 3, 2019 18:19
@mli
Copy link
Member

mli commented Oct 3, 2019

Job PR-957/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-957/2/index.html

@leezu leezu force-pushed the integrationtestscpu branch from 1af4076 to de32e33 Compare October 3, 2019 20:42
@mli
Copy link
Member

mli commented Oct 3, 2019

Job PR-957/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-957/3/index.html

@mli
Copy link
Member

mli commented Oct 3, 2019

Job PR-957/4 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-957/4/index.html

@leezu leezu merged commit 917855b into dmlc:master Oct 4, 2019
@leezu leezu deleted the integrationtestscpu branch October 4, 2019 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants