Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented Sep 3, 2019

Description

Provide padding value during batchification.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

❗ No coverage uploaded for pull request head (fix-pad@5512579). Click here to learn what that means.
The diff coverage is n/a.

@mli
Copy link
Member

mli commented Sep 3, 2019

Job PR-916/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-916/1/index.html

@sxjscience sxjscience merged commit a563293 into dmlc:master Sep 3, 2019
@eric-haibin-lin eric-haibin-lin deleted the fix-pad branch September 17, 2019 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants