[BUGFIX] Fix AMP in finetune_classifier.py

scripts/bert/finetune_classifier.py

@@ -209,6 +209,12 @@
 if args.dtype == 'float16':
     try:
         from mxnet.contrib import amp # pylint: disable=ungrouped-imports
+        # monkey patch amp list since topk does not support fp16
+        amp.lists.symbol.FP32_FUNCS.append('topk')
+        amp.lists.symbol.FP16_FP32_FUNCS.remove('topk')
+        amp.init()
+    except ValueError:
+        # topk is already in the FP32_FUNCS list
         amp.init()
     except ImportError:
         # amp is not available

scripts/tests/test_scripts.py

@@ -355,27 +355,27 @@ def test_finetune_inference(dataset):
                                      '--task_name', dataset] + arguments)
     time.sleep(5)
 
-# Disable Bert finetune
-# @pytest.mark.serial
-# @pytest.mark.gpu
-# @pytest.mark.remote_required
-# @pytest.mark.integration
-# @pytest.mark.parametrize('dataset', ['XNLI', 'LCQMC', 'ChnSentiCorp'])
-# @pytest.mark.skipif(datetime.date.today() < datetime.date(2019, 7, 18),
-#                     reason='Disabled for 4 weeks due to DNS error.')
-# def test_finetune_chinese_inference(dataset):
-#     arguments = ['--log_interval', '100', '--epsilon', '1e-8', '--optimizer',
-#                  'adam', '--gpu', '0', '--max_len', '80', '--only_inference']
-#     process = subprocess.check_call([sys.executable, './scripts/bert/finetune_classifier.py',
-#                                      '--task_name', dataset] + arguments)
-#     time.sleep(5)
+# TODO(haibin): ChnSentiCorp, XNLI, ChnSentiCorp temporarily unavailable
+@pytest.mark.serial
+@pytest.mark.gpu
+@pytest.mark.remote_required
+@pytest.mark.integration
+@pytest.mark.parametrize('dataset', ['XNLI', 'LCQMC', 'ChnSentiCorp'])
+@pytest.mark.skipif(datetime.date.today() < datetime.date(2019, 9, 18),
+                    reason='Disabled for 4 weeks due to DNS error.')
+def test_finetune_chinese_inference(dataset):
+    arguments = ['--log_interval', '100', '--epsilon', '1e-8', '--optimizer',
+                 'adam', '--gpu', '0', '--max_len', '80', '--only_inference']
+    process = subprocess.check_call([sys.executable, './scripts/bert/finetune_classifier.py',
+                                     '--task_name', dataset] + arguments)
+    time.sleep(5)
 
 @pytest.mark.serial
 @pytest.mark.gpu
 @pytest.mark.remote_required
 @pytest.mark.integration
 @pytest.mark.parametrize('dataset', ['WNLI'])
-@pytest.mark.parametrize('dtype', ['float32'])  # TODO fix 'float16'
+@pytest.mark.parametrize('dtype', ['float32', 'float16'])
 def test_finetune_train(dataset, dtype):
     arguments = ['--log_interval', '100', '--epsilon', '1e-8', '--optimizer',
                  'adam', '--gpu', '0', '--epochs', '2', '--dtype', dtype]