This repository was archived by the owner on Jan 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 528
[CI] AWS Batch serverless CI Pipeline for parallel notebook execution during website build step #791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
==========================================
- Coverage 90.5% 81.49% -9.01%
==========================================
Files 64 64
Lines 6295 6295
==========================================
- Hits 5697 5130 -567
- Misses 598 1165 +567
|
3531aff
to
eef2b36
Compare
0196a01
to
41a868e
Compare
Job PR-791/113 is complete. |
85c3420
to
31f8f02
Compare
- Automatically set correct working directory - Manually set encoding; System environment may not be set up correctly for inferring encoding
1c840b4
to
aae0145
Compare
Job PR-791/123 is complete. |
@szha @eric-haibin-lin please review and merge if everything looks good to you |
szha
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks.
Integration is taking ~55m which means we should probably have another way of testing the scripts.
eric-haibin-lin
approved these changes
Jun 27, 2019
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently our CI takes more than 1 hour, running multiple Jenkinsfiles in parallel. The longest running is GluonNLP-py3-master-gpu-doc with expected runtime to gradually worsen as we add more examples.
This PR speeds up the GluonNLP-py3-master-gpu-doc run by parallelizing execution of our example notebooks with AWS Batch, scheduling a separate Job for each notebook. As a result, GluonNLP-py3-master-gpu-doc only runs 30 minutes, out of which 10 minutes are spent waiting for AWS Batch to begin execution. As AWS Batch service is expected to improve, we may hope for an execution time of ~20 minutes in the future.
Now, GluonNLP-py3-master-gpu-integration and GluonNLP-py3-gpu-integration are our longest running Jenkinsfiles.
Checklist
Essentials
Changes