Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

eric-haibin-lin
Copy link
Member

Description

As title. Everything should go through nlp.model.get_model. @szha @leezu

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner June 12, 2019 21:27
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

❗ No coverage uploaded for pull request head (get_bert_model_api@7a04b89). Click here to learn what that means.
The diff coverage is n/a.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

❗ No coverage uploaded for pull request head (get_bert_model_api@7a04b89). Click here to learn what that means.
The diff coverage is n/a.

@mli
Copy link
Member

mli commented Jun 12, 2019

Job PR-767/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-767/1/index.html

@eric-haibin-lin
Copy link
Member Author

@rich-junwang FYI we are replacing get_bert_model API with the get_model API

@mli
Copy link
Member

mli commented Jun 13, 2019

Job PR-767/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-767/2/index.html

@mli
Copy link
Member

mli commented Jun 13, 2019

Job PR-767/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-767/3/index.html

@szha szha merged commit 022b437 into dmlc:master Jun 13, 2019
@eric-haibin-lin eric-haibin-lin deleted the get_bert_model_api branch October 12, 2019 00:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants