Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jun 8, 2019

After enabling linkcheck again in #752, it turns out that on the master branch linkcheck continues to fail due to issues with our the symbolic link to the model_zoo. There have been a number of bugfixes for sphinx linkcheck in recent versions. Thus let's update the version first before investigating the current continued failure.

Also, nbconvert 5.5 now supports pandoc 2.

@leezu leezu requested a review from szha as a code owner June 8, 2019 11:03
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

❗ No coverage uploaded for pull request head (fixlinks@bf2733f). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #756 into master will increase coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   89.95%   90.71%   +0.75%     
==========================================
  Files          64       64              
  Lines        6064     6064              
==========================================
+ Hits         5455     5501      +46     
+ Misses        609      563      -46
Impacted Files Coverage Δ
src/gluonnlp/data/stream.py 89.61% <0%> (+0.54%) ⬆️
src/gluonnlp/model/sequence_sampler.py 92.22% <0%> (+15.9%) ⬆️

leezu added 2 commits June 8, 2019 11:27
There have been a number of bugfixes for sphinx linkcheck. Let's update the
version first before investigating the current continued failure.
@mli
Copy link
Member

mli commented Jun 8, 2019

Job PR-756/5 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-756/5/index.html

@leezu leezu requested a review from eric-haibin-lin June 8, 2019 12:42
@szha szha merged commit 0a0bb6c into dmlc:master Jun 8, 2019
@leezu leezu deleted the fixlinks branch June 8, 2019 19:14
szha pushed a commit to szha/gluon-nlp that referenced this pull request Jun 13, 2019
szha added a commit that referenced this pull request Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants