-
Notifications
You must be signed in to change notification settings - Fork 528
[BiDAF-QANet] Common data processing logic for BiDAF and QANet #739
Conversation
Codecov Report
|
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
=========================================
+ Coverage 90.56% 90.7% +0.14%
=========================================
Files 65 64 -1
Lines 6071 6295 +224
=========================================
+ Hits 5498 5710 +212
- Misses 573 585 +12
|
Job PR-739/1 is complete. |
Job PR-739/2 is complete. |
Job PR-739/3 is complete. |
Job PR-739/4 is complete. |
Job PR-739/5 is complete. |
Job PR-739/6 is complete. |
Job PR-739/7 is complete. |
Job PR-739/8 is complete. |
Job PR-739/9 is complete. |
Job PR-739/10 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. I'm totally fine if they're addressed in later PRs
Job PR-739/12 is complete. |
Job PR-739/13 is complete. |
Job PR-739/14 is complete. |
Description
This is the first PR from the "Merge QANet & BiDAF" project - https://github.com/dmlc/gluon-nlp/projects/7 In this commit I extract common data preprocessing code and put it as a separate module.
Checklist
Essentials