Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

eric-haibin-lin
Copy link
Member

Description

@szha

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner May 21, 2019 00:24
@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #716 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #716     +/-   ##
=========================================
+ Coverage   90.53%   90.63%   +0.1%     
=========================================
  Files          65       65             
  Lines        5991     5991             
=========================================
+ Hits         5424     5430      +6     
+ Misses        567      561      -6
Impacted Files Coverage Δ
src/gluonnlp/data/dataloader.py 88.79% <0%> (+5.17%) ⬆️

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

❗ No coverage uploaded for pull request head (best-acc@b8042c4). Click here to learn what that means.
The diff coverage is n/a.

@mli
Copy link
Member

mli commented May 21, 2019

Job PR-716/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-716/1/index.html

@mli
Copy link
Member

mli commented May 21, 2019

Job PR-716/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-716/2/index.html

@szha szha merged commit c80b771 into dmlc:master May 21, 2019
@eric-haibin-lin eric-haibin-lin deleted the best-acc branch February 2, 2020 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants