Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

eric-haibin-lin
Copy link
Member

@eric-haibin-lin eric-haibin-lin commented May 8, 2019

Description

http://ci.mxnet.io/blue/organizations/jenkins/GluonNLP-py3-master-gpu-doc/detail/PR-648/1/pipeline shows that the BERT tutorial cannot run with the bash command. It's still not clear why it happens to me. This PR tries to replace bash with python code.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner May 8, 2019 03:21
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

❗ No coverage uploaded for pull request head (fix-tutorial@e792529). Click here to learn what that means.
The diff coverage is n/a.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #698 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #698   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files          64       64           
  Lines        5887     5887           
=======================================
  Hits         5354     5354           
  Misses        533      533

@mli
Copy link
Member

mli commented May 8, 2019

Job PR-698/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-698/1/index.html

@eric-haibin-lin eric-haibin-lin merged commit c854c03 into dmlc:master May 8, 2019
@eric-haibin-lin eric-haibin-lin deleted the fix-tutorial branch May 9, 2019 04:54
astonzhang pushed a commit that referenced this pull request May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants