This repository was archived by the owner on Jan 15, 2024. It is now read-only.
[BUGFIX] Fix mlm_loss reporting for eval dataset #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
=========================================
+ Coverage 90.94% 91.04% +0.1%
=========================================
Files 64 64
Lines 5887 5887
=========================================
+ Hits 5354 5360 +6
+ Misses 533 527 -6
|
|
Job PR-696/1 is complete. |
fierceX
approved these changes
May 7, 2019
szha
approved these changes
May 7, 2019
astonzhang
pushed a commit
that referenced
this pull request
May 10, 2019
* fix eval precision * remove dtype cast * add doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
total_mlm_losswas only updated everylog_intervalsteps, and losses of last few steps are not added to the total loss. This PR fixes that.@khetan2 @paperplanet @AI-richard FYI
Checklist
Essentials