This repository was archived by the owner on Jan 15, 2024. It is now read-only.
[TUTORIAL] Fix README WikiText2 example #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-haibin-lin
approved these changes
Apr 28, 2019
|
@szha is the CI down? |
|
@eric-haibin-lin a recent kernel image upgrade on the CI server caused nvidia drivers to fail. I reverted the kernel images just now so hopefully, things should be working now |
szha
approved these changes
May 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 65.27% 65.03% -0.25%
==========================================
Files 143 143
Lines 13279 13117 -162
==========================================
- Hits 8668 8530 -138
+ Misses 4611 4587 -24
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 65.27% 65.03% -0.25%
==========================================
Files 143 143
Lines 13279 13117 -162
==========================================
- Hits 8668 8530 -138
+ Misses 4611 4587 -24
|
|
Job PR-681/11 is complete. |
|
@crcrpar thank you for the fix! |
|
My pleasure! |
gigasquid
pushed a commit
to gigasquid/gluon-nlp
that referenced
this pull request
May 6, 2019
astonzhang
pushed a commit
that referenced
this pull request
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes
nlp.data.WikiText2(segment='train')[0][0:5]tonlp.data.WikiText2(segment='train')[0:5]becausenlp.data.WikiText2(segment='train')[0][0:5]is '='.Checklist
Essentials
Changes
Comments