Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

rongruosong
Copy link
Contributor

@rongruosong rongruosong commented Apr 20, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@rongruosong rongruosong requested a review from szha as a code owner April 20, 2019 10:51
@mli
Copy link
Member

mli commented Apr 20, 2019

Job PR-670/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-670/1/index.html

@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #670 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   63.74%   63.74%           
=======================================
  Files         141      141           
  Lines       12902    12902           
=======================================
  Hits         8224     8224           
  Misses       4678     4678
Flag Coverage Δ
#PR670 63.74% <ø> (?)
#master ?
#notserial 42.61% <ø> (-0.02%) ⬇️
#py2 63.49% <ø> (ø) ⬆️
#py3 63.62% <ø> (ø) ⬆️
#serial 49.22% <ø> (ø) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 20, 2019

Codecov Report

Merging #670 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   63.74%   63.74%           
=======================================
  Files         141      141           
  Lines       12902    12902           
=======================================
  Hits         8224     8224           
  Misses       4678     4678
Flag Coverage Δ
#PR670 63.74% <ø> (?)
#master ?
#notserial 42.61% <ø> (-0.02%) ⬇️
#py2 63.49% <ø> (ø) ⬆️
#py3 63.62% <ø> (ø) ⬆️
#serial 49.22% <ø> (ø) ⬆️

@szha
Copy link
Member

szha commented Apr 21, 2019

@rongruosong good catch. Thank you for the fix!

Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rongruosong thanks!

@eric-haibin-lin eric-haibin-lin merged commit 12c97a0 into dmlc:master Apr 22, 2019
gigasquid pushed a commit to gigasquid/gluon-nlp that referenced this pull request May 6, 2019
* fix code comment

* fix comment of train_valid_split
astonzhang pushed a commit that referenced this pull request May 10, 2019
* fix code comment

* fix comment of train_valid_split
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants