Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

[DOC] Add alternative link for bert scripts #667

Merged
merged 1 commit into from
Apr 19, 2019
Merged

[DOC] Add alternative link for bert scripts #667

merged 1 commit into from
Apr 19, 2019

Conversation

eric-haibin-lin
Copy link
Member

Description

attempt to mitigate issue #666

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@eric-haibin-lin eric-haibin-lin requested a review from szha as a code owner April 18, 2019 22:14
@mli
Copy link
Member

mli commented Apr 18, 2019

Job PR-667/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-667/1/index.html

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #667 into master will increase coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   63.14%   63.74%   +0.59%     
==========================================
  Files         141      141              
  Lines       13023    12902     -121     
==========================================
  Hits         8224     8224              
+ Misses       4799     4678     -121
Flag Coverage Δ
#PR639 ?
#PR667 63.74% <ø> (?)
#master ?
#notserial 42.62% <ø> (+0.41%) ⬆️
#py2 63.49% <ø> (+0.59%) ⬆️
#py3 63.62% <ø> (+0.59%) ⬆️
#serial 49.22% <ø> (+0.46%) ⬆️

1 similar comment
@codecov
Copy link

codecov bot commented Apr 18, 2019 •
edited
Loading

Codecov Report

Merging #667 into master will increase coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   63.14%   63.74%   +0.59%     
==========================================
  Files         141      141              
  Lines       13023    12902     -121     
==========================================
  Hits         8224     8224              
+ Misses       4799     4678     -121
Flag Coverage Δ
#PR639 ?
#PR667 63.74% <ø> (?)
#master ?
#notserial 42.62% <ø> (+0.41%) ⬆️
#py2 63.49% <ø> (+0.59%) ⬆️
#py3 63.62% <ø> (+0.59%) ⬆️
#serial 49.22% <ø> (+0.46%) ⬆️

@szha szha requested a review from vanewu April 19, 2019 06:50
@astonzhang astonzhang merged commit 58237c0 into master Apr 19, 2019
@szha szha deleted the link-patch branch April 19, 2019 21:58
gigasquid pushed a commit to gigasquid/gluon-nlp that referenced this pull request May 6, 2019
@eric-haibin-lin @gigasquid
Update bert.md (dmlc#667)
9ec22cb
astonzhang pushed a commit that referenced this pull request May 10, 2019
@eric-haibin-lin
Update bert.md (#667)
20891b7
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vanewu vanewu Awaiting requested review from vanewu

2 more reviewers

@szha szha szha approved these changes

@astonzhang astonzhang astonzhang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eric-haibin-lin @mli @szha @astonzhang