Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

hankcs
Copy link
Contributor

@hankcs hankcs commented Mar 29, 2019

Description

Fix multiprocessing bug which causes unnecessary dispatching to single worker.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Only consider nworker >= 2 as the condition for multiprocessing.

Comments

I guess the other condition branch is intended for serial execution, while it will never be triggered when nworker is 1.

@hankcs hankcs requested a review from szha as a code owner March 29, 2019 02:06
@mli
Copy link
Member

mli commented Mar 29, 2019

Job PR-649/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-649/1/index.html

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #649 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   63.76%   63.77%   +<.01%     
==========================================
  Files         141      141              
  Lines       12870    12870              
==========================================
+ Hits         8207     8208       +1     
+ Misses       4663     4662       -1
Flag Coverage Δ
#PR435 66.95% <ø> (?)
#PR466 67.03% <ø> (?)
#PR588 67.03% <ø> (?)
#PR612 67.03% <ø> (?)
#PR639 66.93% <ø> (?)
#PR640 66.93% <ø> (?)
#PR647 ?
#PR648 67.03% <ø> (?)
#PR649 67.03% <ø> (?)
#master 63.77% <ø> (ø) ⬆️
#notserial 42.67% <ø> (+0.03%) ⬆️
#py2 63.53% <ø> (ø) ⬆️
#py3 63.65% <ø> (+0.04%) ⬆️
#serial 49.18% <ø> (-0.04%) ⬇️

@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #649 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   63.76%   63.72%   -0.04%     
==========================================
  Files         141      141              
  Lines       12870    12870              
==========================================
- Hits         8207     8202       -5     
- Misses       4663     4668       +5
Flag Coverage Δ
#PR649 63.72% <0%> (?)
#master ?
#notserial 42.62% <0%> (-0.02%) ⬇️
#py2 63.48% <0%> (-0.04%) ⬇️
#py3 63.61% <0%> (ø) ⬆️
#serial 49.18% <0%> (-0.04%) ⬇️

@astonzhang astonzhang self-assigned this Mar 29, 2019
@astonzhang astonzhang self-requested a review March 29, 2019 22:12
@astonzhang astonzhang removed their assignment Mar 29, 2019
@mli
Copy link
Member

mli commented Mar 31, 2019

Job PR-649/3 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-649/3/index.html

@astonzhang astonzhang merged commit bb3ab0c into dmlc:master Mar 31, 2019
gigasquid pushed a commit to gigasquid/gluon-nlp that referenced this pull request May 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants