Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

MoisesHer
Copy link
Contributor

Description

FEATURE: multi-tensor Update - Adam Optimizer

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Modification in Adam optimizer for adding the possibility of updating several weight tensors within same operator. This expose more parallelism several. Up to 50 tensors can be updated within the operator. Observed ~7% throughput increase on V100. The multi-tensor version will be used when MXNET_OPTIMIZER_AGGREGATION_SIZE > 1
  • Added multi-tensor Adam optimizer test

Comments

@MoisesHer MoisesHer requested a review from a team as a code owner January 15, 2020 01:36
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #1111 into master will decrease coverage by 0.04%.
The diff coverage is 81.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
- Coverage   88.25%   88.21%   -0.05%     
==========================================
  Files          67       67              
  Lines        6275     6302      +27     
==========================================
+ Hits         5538     5559      +21     
- Misses        737      743       +6
Impacted Files Coverage Δ
src/gluonnlp/optimizer/bert_adam.py 87.32% <81.57%> (-5.86%) ⬇️

@mli
Copy link
Member

mli commented Jan 15, 2020

Job PR-1111/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1111/1/index.html

@eric-haibin-lin eric-haibin-lin added the release focus Progress focus for release label Jan 15, 2020
@leezu leezu requested a review from eric-haibin-lin January 15, 2020 14:53
@eric-haibin-lin eric-haibin-lin merged commit 7698e71 into dmlc:master Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release focus Progress focus for release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants