Skip to content
This repository was archived by the owner on Jan 15, 2024. It is now read-only.

Conversation

liuzh47
Copy link
Contributor

@liuzh47 liuzh47 commented Nov 14, 2019

Description

(Brief description on what this PR is about)
[MAINTENANCE]This fix replaces magic numbers with the name

Checklist

Essentials

  • [X ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • [ X] Changes are complete (i.e. I finished coding on this PR)
  • [ X] All changes have test coverage
  • [ X] Code is well-documented

cc @dmlc/gluon-nlp-team

@liuzh47 liuzh47 requested a review from a team as a code owner November 14, 2019 03:57
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #1006 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1006   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files          67       67           
  Lines        6254     6254           
=======================================
  Hits         5521     5521           
  Misses        733      733

@mli
Copy link
Member

mli commented Nov 14, 2019

Job PR-1006/1 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1006/1/index.html

@liuzh47 liuzh47 force-pushed the transformer_readability branch from 032e702 to 5f3f430 Compare December 2, 2019 09:53
@mli
Copy link
Member

mli commented Dec 2, 2019

Job PR-1006/2 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1006/2/index.html

@szha szha merged commit d0b7486 into dmlc:master Dec 2, 2019
@liuzh47 liuzh47 deleted the transformer_readability branch December 3, 2019 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants