Skip to content

Conversation

@Moth-Tolias
Copy link
Contributor

this silences some of the deprecation warnings emitted when building.

Copy link
Member

@WebFreak001 WebFreak001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you would need to bump the minimum libdparse version for this change. (see CI)

@Moth-Tolias
Copy link
Contributor Author

should work now?

@Moth-Tolias
Copy link
Contributor Author

oh dear, that doesn't look right...

@Moth-Tolias
Copy link
Contributor Author

now tested to work with dub upgrade.

@WebFreak001
Copy link
Member

WebFreak001 commented Feb 26, 2023

you forgot to set the exact version to use when compiling D-Scanner as executable in dub.selections.json

the version range in dub.json is for library users to support multiple libdparse versions

nvm you are not upgrading libdparse

@WebFreak001
Copy link
Member

it seems that the new dsymbol versions doesn't work with old libdparse versions, you probably have to bump the minimum libdparse version some more.

@Moth-Tolias
Copy link
Contributor Author

if it doesn't work this time i will become jokerfied

@WebFreak001 WebFreak001 merged commit 9b171c4 into dlang-community:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants