fix #791 #881
Merged
fix #791 #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
requested changes
Dec 28, 2022
There was a problem hiding this comment.
this doesn't seem to change the package / package(xyz) behavior referenced in #880, but only disables this check inside aggregates. (which seems wrong)
Also this is missing a unittest to check the code from the referenced issue.
|
different issue, this PR is for an issue I opened in 2020 |
|
ah sorry, missed that. This is still missing a test for the code from that issue though. |
|
just added tests, not sure if github notifies for that so commenting this just in case |
WebFreak001
reviewed
Dec 28, 2022
|
|
||
| abstract int method(); // [warn]: 'abstract' attribute is redundant in interface declarations | ||
| } | ||
| }c, sac); |
There was a problem hiding this comment.
can you also test static methods? (as mentioned in #791)
WebFreak001
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.