Skip to content

Conversation

mfdeveloper
Copy link

@mfdeveloper mfdeveloper commented Feb 19, 2022

Hi there!

I found some problems to build the main C++ .dll to use with the wrappers (in my case, on .net). This PR contains some fixes to avoid the compiling errors.

Also, I added a step by step guide in docs/README.md to describe which dependencies you should install first, and how generate the .dll.

Besides that, I would like to suggest:

  1. Publish/upload the all "packages" (e.g main .dll, .jar...) to Releases in this repository, and put the current stable version number
  2. Merge and "adapt" the PR Build Tolk using CMake and publish artifacts using Github workflow #19 to use CMake to compile the C++ dll as a alternative to use nmake or jom with `Makefile's. That will be more easy to upgrade this project to a "cross platform" approach in the future 😄

@@ -16,7 +16,7 @@ class ScreenReaderDriver {
hasSpeech(speech),
hasBraille(braille)
{}
ScreenReaderDriver& operator=(const ScreenReaderDriver&) {}
ScreenReaderDriver& operator=(const ScreenReaderDriver&);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this cause a linker error?

I think what you want to do is this:
ScreenReaderDriver& operator=(const ScreenReaderDriver&) = delete;
to prevent copying.

inkydragon referenced this pull request in sig-a11y/tolk Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants