Fixed #35986 -- Fixed test classes with @translation.override decorator.
#19358
+23
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Simon Charette <[email protected]>
sarahboyce
changed the title
@translation.override decorator@translation.override decorator.
sarahboyce
approved these changes
Apr 8, 2025
felixxm
reviewed
Apr 9, 2025
| @@ -31,7 +31,7 @@ def utc(value): | |||
| """ | |||
| Convert a datetime to UTC. | |||
| """ | |||
| return do_timezone(value, datetime.UTC) | |||
| return do_timezone(value, UTC) | |||
There was a problem hiding this comment.
This is a fix for regression in efb7f9c, not related with this patch.
There was a problem hiding this comment.
It seems that we don't have tests for the utc filter 🤔
There was a problem hiding this comment.
It did start to fail with these changes as some tests started to "run" which were not running before
But you're right it should have been two commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-35986
Branch description
Replace class-level
@translation.overridedecorator withenterClassContext()intest classes. This ensures proper test discovery and execution of test classes
using translation overrides.
Changes made:
enterClassContext()instead of decoratorChecklist
mainbranch.