Skip to content

Conversation

arynxd
Copy link
Contributor

@arynxd arynxd commented Aug 6, 2021

From #45

aryn added 2 commits August 6, 2021 21:20
@arynxd
Copy link
Contributor Author

arynxd commented Aug 6, 2021

Additionally i cant see any existing impl for uploading multi-part-form-data on dev, but i know topi has it impld somewhere. As such i will hold off on adding AddGuildSticker

@arynxd arynxd marked this pull request as ready for review August 6, 2021 20:47
@arynxd arynxd requested a review from Skye-31 August 6, 2021 20:47
Skye-31
Skye-31 previously approved these changes Aug 8, 2021
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to pull from the reformat branch & change the target branch :)

@topi314 topi314 linked an issue Aug 9, 2021 that may be closed by this pull request
# Conflicts:
#	api/disgo.go
#	api/guild.go
#	api/message.go
#	api/restclient.go
#	discord/sticker_pack.go
#	internal/disgo_impl.go
#	internal/restclient_impl.go
@topi314 topi314 changed the base branch from development to patch/package-reformat September 13, 2021 00:11
@topi314
Copy link
Member

topi314 commented Sep 13, 2021

this is not finished & needs testing

@topi314 topi314 marked this pull request as draft September 13, 2021 00:12
# Conflicts:
#	_examples/slash_commands/http/go.mod
# Conflicts:
#	_examples/disgo_builder/go.sum
#	_examples/disgo_opts/go.sum
#	_examples/message_collector/go.sum
#	_examples/oauth2/go.sum
#	_examples/slash_commands/gateway/go.sum
#	_examples/slash_commands/http/go.sum
#	_examples/test/go.mod
#	_examples/webhook/go.sum
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm this should be rdy to review
need to test some stuff tomorrow tho

@topi314 topi314 requested a review from Skye-31 September 13, 2021 23:39
@topi314 topi314 assigned topi314 and unassigned arynxd Sep 13, 2021
@topi314 topi314 marked this pull request as ready for review September 13, 2021 23:40
@topi314 topi314 merged commit 585236c into patch/package-reformat Sep 15, 2021
@topi314 topi314 deleted the feature/stickers branch September 15, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Sticker

3 participants