Skip to content

Implement collectors (Closes #60) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: fix README example
merged 20 commits into from
Oct 9, 2021
Merged

Implement collectors (Closes #60) #62

merged 20 commits into from
Oct 9, 2021

Conversation

@arynxd
Copy link
Contributor

@arynxd arynxd commented Aug 5, 2021

Implements collectors from #60

@arynxd arynxd marked this pull request as ready for review August 5, 2021 20:21
@arynxd
Copy link
Contributor Author

arynxd commented Aug 5, 2021

Will implement context menus when they release fully

@arynxd arynxd self-assigned this Aug 5, 2021
@arynxd arynxd requested a review from topi314 August 5, 2021 20:21
topi314
topi314 previously requested changes Aug 6, 2021
View reviewed changes
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except reaction collector everything is fine
just being picky on naming

@arynxd @topi314
Apply naming changes
fff3bf2 
Co-authored-by: ToπSenpai <[email protected]>
@arynxd arynxd requested a review from topi314 August 6, 2021 09:31
Skye-31
Skye-31 previously approved these changes Aug 6, 2021
View reviewed changes
@arynxd arynxd requested a review from Skye-31 August 6, 2021 21:22
Skye-31
Skye-31 previously approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@Skye-31 Skye-31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@topi314
Copy link
Member

topi314 commented Aug 9, 2021

Feel free to pull from the reformat branch & change the target branch :)

topi314
topi314 requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above lol

@Skye-31 Skye-31 changed the base branch from development to patch/package-reformat September 21, 2021 11:22
@topi314 topi314 changed the base branch from patch/package-reformat to development September 26, 2021 14:56
@topi314 topi314 requested a review from Skye-31 October 9, 2021 15:42
topi314
topi314 previously approved these changes Oct 9, 2021
View reviewed changes
@topi314
Copy link
Member

topi314 commented Oct 9, 2021

the collectors were bound to a certain channel or message before which was kinda weird
without those restrictions they should be better to use

@topi314 topi314 merged commit fe5aada into development Oct 9, 2021
@topi314 topi314 deleted the feature/collectors branch October 9, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skye-31 Skye-31 Skye-31 approved these changes

@topi314 topi314 topi314 left review comments

Assignees

@arynxd arynxd

Labels

type:enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arynxd @topi314 @Skye-31