Add ResumeShard method and ShardState struct to manage shard session and sequence #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
force-pushed
the
feature/shardmanager-shard-state
branch
from
40cdcc7 to
4075702
Compare
topi314
force-pushed
the
feature/shardmanager-shard-state
branch
from
4075702 to
cb88deb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
topi314
force-pushed
the
feature/shardmanager-shard-state
branch
from
cb88deb to
1d1221e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces shard resumption functionality by adding a ResumeShard method and a ShardState struct to manage session IDs and sequences for Discord shards. This enables the shard manager to resume existing shard connections instead of always creating new ones.
- Add
ShardStatestruct to store session ID and sequence for shard resumption - Change
ShardIDsmap frommap[int]struct{}tomap[int]ShardStateto track shard states - Add
ResumeShardmethod to allow resuming specific shards with session data
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sharding/shard_manager_config.go | Adds ShardState struct and updates configuration to support shard state tracking |
| sharding/shard_manager.go | Implements ResumeShard method and updates shard opening logic to handle session resumption |
topi314
force-pushed
the
feature/shardmanager-shard-state
branch
from
1ebd392 to
54e2700
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.