Make the Audit Log Change Key typed and add constants for its possible values #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
reviewed
Aug 12, 2024
topi314
approved these changes
Aug 12, 2024
|
thanks good timing on this too |
topi314
added a commit
that referenced
this pull request
Aug 12, 2024
* fix audit log changes struct * Make the Audit Log Change Key typed and add constants for its possible values (#377) * fix: make AuditLogChange.Key typed with constants instead of just a string. * chore: move type declaration to immediately before related definitions. --------- Co-authored-by: Vegard Berg <[email protected]> --------- Co-authored-by: Vegard Berg <[email protected]> Co-authored-by: Vegard Berg <[email protected]>
apricotbucket28
pushed a commit
to apricotbucket28/disgo
that referenced
this pull request
Feb 16, 2025
* fix audit log changes struct * Make the Audit Log Change Key typed and add constants for its possible values (disgoorg#377) * fix: make AuditLogChange.Key typed with constants instead of just a string. * chore: move type declaration to immediately before related definitions. --------- Co-authored-by: Vegard Berg <[email protected]> --------- Co-authored-by: Vegard Berg <[email protected]> Co-authored-by: Vegard Berg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AuditLogChange.Keyto beAuditLogChangeKeyinstead ofstring, and adds constants for its valid values.This should make it a bit easier to match desired keys, since they will be defined in the library.