Skip to content

add SetFooterIconf, SetImagef, SetThumbnailf and SetURLf #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2022
Merged

add SetFooterIconf, SetImagef, SetThumbnailf and SetURLf #204

merged 2 commits into from
Oct 14, 2022

Conversation

@itasli
Copy link
Contributor

@itasli itasli commented Oct 14, 2022

No description provided.

topi314
topi314 requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more elegant to just call SetFooterIcon from SetFooterIconf instead of copying the code

You can also add the last missing ones:

  • SetAuthorNamef
  • SetAuthorURLf
  • SetAuthorIconf
  • SetFooterTextf

@topi314 topi314 merged commit 17ccdf3 into disgoorg:development Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@topi314 topi314 topi314 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@itasli @topi314