Skip to content

Missing/incorrect Rest endpoints #452

@Readeem

Description

@Readeem

Is your feature request related to a problem? Please describe.
I need access to many various Discord features for my project.
In this case, I need a possibility to fetch messages as described in Discord developer documentation,
but some of the endpoints from this library in rest/rest_enpoints.go are incorrect.

Describe the solution you'd like
Fix the GetFollowupMessage endpoint, which is currently defined as follows:

GetFollowupMessage    = NewNoBotAuthEndpoint(http.MethodGet, "/webhooks/{application.id}/{interaction.token}")

when it should be (according to Discord docs):

GetFollowupMessage    = NewNoBotAuthEndpoint(http.MethodGet, "/webhooks/{application.id}/{interaction.token}/messages/{message.id}")

Also, this library turns out to be missing endpoint GetWebhookMessage docs. I would like to see this endpoint implemented.

Since I'm making this feature request, I will also point at some of bugs that I've found in the codebase.
I don't know if they are still present in the main branch, but here they are:

  1. gateway/gateway_events.go, line 587, EventMessageDeleteBulk struct, wrong json tag "id" instead of "ids". Docs
  2. handlers/guild_scheduled_event_handlers.go, line 33, gatewayHandlerGuildScheduledEventDelete func, "event" parameter has "EventGuildScheduledEventCreate" type instead of "EventGuildScheduledEventDelete" type, which effectively prevents this event from firing.

Describe alternatives you've considered

Additional context
I wanna add some words of support for maintainers of this library, guys, you did a great job developing this library!
Modularity of disgo helps me a lot in my project. If only I had possibilities I would also consider supporting this library materially, but unfortunately I do not have ways to do so. Wish you the best.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions