Skip to content

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jun 16, 2021

Please describe the changes this PR makes and why it should be merged:

  • Removes deprecated sticker.asset (which is just an empty string now)
  • Updates URL (old one doesn't work anymore)
  • Adds sticker properties: type, packID, available, guild, guildID, user, sortValue, fetchPack(), edit(), delete(), equals()
  • Adds StickerPack
  • Adds Client#fetchSticker(id)
  • Adds Client#fetchNitroStickerPacks()
  • Renames MANAGE_EMOJIS permission to MANAGE_EMOJIS_AND_STICKERS as requested by Jethro, to reflect client update
  • Adds sending stickers (stickers in MessageOptions)
  • Adds Guild#stickers and GuildStickerManager
  • Adds stickerCreate, stickerUpdate, and stickerDelete events
  • Renames GUILD_EMOJIS intent to GUILD_EMOJIS_AND_STICKERS
  • Adds sticker audit log events

discord/discord-api-docs#3127
discord/discord-api-docs#3171
discord/discord-api-docs#3128

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@advaith1 advaith1 changed the title feat(Sticker): update sticker properties feat(Sticker): update sticker properties and add StickerPack Jun 17, 2021
@advaith1
Copy link
Contributor Author

ok, I think this is ready for review?

it doesn't add GuildStickerManager or the guild sticker update gw event bc those can't really be tested now, but I've tested everything added

@advaith1 advaith1 marked this pull request as ready for review June 17, 2021 06:10
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three small things, otherwise LGTM

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just three small things, otherwise LGTM

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looking good

@kyranet kyranet requested a review from SpaceEEC June 19, 2021 22:56
@iCrawl iCrawl self-requested a review July 7, 2021 12:41
@advaith1 advaith1 changed the title feat(Sticker): update sticker properties and add StickerPack feat(Sticker): updates, sticker packs, and guild stickers Jul 7, 2021
@advaith1 advaith1 requested a review from vladfrangu July 7, 2021 19:15
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase

@iCrawl
Copy link
Member

iCrawl commented Jul 17, 2021

This needs a rebase.

@mustafa-archived
Copy link

you aware changes weren't merged?

@kyranet
Copy link
Member

kyranet commented Jul 19, 2021

Upstream PR has landed, and this needs a rebase 😄

@iCrawl iCrawl merged commit 54d6a3a into discordjs:master Jul 19, 2021
@advaith1 advaith1 deleted the sticker-updates branch July 19, 2021 23:18
ckohen added a commit to ckohen/discord.js-modules that referenced this pull request Nov 14, 2021
ckohen added a commit to ckohen/discord.js-modules that referenced this pull request Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.