Skip to content

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Sep 1, 2025

Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-js Ready Ready Preview Comment Sep 14, 2025 8:07am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ignored Ignored Preview Sep 14, 2025 8:07am

@Jiralite Jiralite force-pushed the feat/more-labels-in-builders branch from 0cdbba2 to b722b62 Compare September 10, 2025 08:31
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 58.82353% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.24%. Comparing base (90aac12) to head (82e4839).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/builders/src/components/label/Label.ts 28.57% 20 Missing ⚠️
packages/builders/src/interactions/modals/Modal.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11078      +/-   ##
==========================================
- Coverage   44.41%   44.24%   -0.18%     
==========================================
  Files         312      312              
  Lines       17900    17879      -21     
  Branches     1791     1771      -20     
==========================================
- Hits         7951     7911      -40     
- Misses       9937     9956      +19     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite marked this pull request as ready for review September 10, 2025 09:06
@Jiralite Jiralite requested a review from a team as a code owner September 10, 2025 09:06
@Jiralite Jiralite changed the title feat: More label components and text display in modal feat!: More label components and text display in modal Sep 10, 2025
Copy link
Member

@didinele didinele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't read tests nor did I review the prev PRs for this feature, but LGTM

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Sep 13, 2025
@Jiralite Jiralite merged commit b66f52f into main Sep 14, 2025
8 checks passed
@Jiralite Jiralite deleted the feat/more-labels-in-builders branch September 14, 2025 08:09
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Select menus and text display support for modals for @discordjs/builders

4 participants