Skip to content

Conversation

jNullj
Copy link
Contributor

@jNullj jNullj commented Aug 22, 2025

Please describe the changes this PR makes and why it should be merged:

Support for DAVE protocol was added at #10735
Discord mention this in a past blog post here and it seems like this is about to be a requirement.
As I discovered while I got repeated crashes due to discord not downgrading my connection to a non e2ee connection!
It could be very useful if i known about this dependency while searching for a solution.
It could be also a good idea to inform users in the release notes/changelog so they know it's a good idea to add this dependency.

Made another PR for the guide as well #11145

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@jNullj jNullj requested a review from a team as a code owner August 22, 2025 20:35
@jNullj jNullj requested a review from SpaceEEC August 22, 2025 20:35
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js Ignored Ignored Preview Oct 11, 2025 6:28pm
discord-js-guide Ignored Ignored Preview Oct 11, 2025 6:28pm

@jNullj jNullj changed the title Voice readme dave protocol docs(voice): add DAVE dependency section Aug 22, 2025
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js Oct 11, 2025
@Jiralite Jiralite added this to the voice 0.20.0 milestone Oct 11, 2025
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.08%. Comparing base (0c2975e) to head (ca88f99).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11061      +/-   ##
==========================================
- Coverage   44.19%   44.08%   -0.11%     
==========================================
  Files         313      310       -3     
  Lines       18093    17659     -434     
  Branches     1796     1744      -52     
==========================================
- Hits         7996     7785     -211     
+ Misses      10085     9862     -223     
  Partials       12       12              
Flag Coverage Δ
voice 60.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review in Progress

Development

Successfully merging this pull request may close these issues.

2 participants