Skip to content

refactor: use get guild role endpoint #10443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2024
Merged

refactor: use get guild role endpoint #10443

merged 4 commits into from
Aug 21, 2024

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Aug 14, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Makes use of the new Get Guild Role endpoint on RoleManager#fetch(id) and added a getRole() method on GuildsAPI

Upstream:

Depends on:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@almeidx almeidx requested a review from a team as a code owner August 14, 2024 18:20
@vercel Vercel
Copy link

vercel bot commented Aug 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 10:10pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 21, 2024 10:10pm

@almeidx almeidx force-pushed the feat/get-guild-role branch from b44318c to b0326ac Compare August 14, 2024 18:21
@almeidx almeidx marked this pull request as draft August 14, 2024 18:25
@almeidx almeidx mentioned this pull request Aug 15, 2024
Merged
@almeidx almeidx marked this pull request as ready for review August 20, 2024 09:40
vladfrangu
vladfrangu approved these changes Aug 20, 2024
View reviewed changes
@kodiakhq kodiakhq bot merged commit bba0e72 into main Aug 21, 2024
@kodiakhq kodiakhq bot deleted the feat/get-guild-role branch August 21, 2024 22:14
@Mocksybren Mocksybren mentioned this pull request Sep 24, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request Sep 24, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 24, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 26, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 27, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 27, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 27, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 28, 2024
Open
@ReiseArnor ReiseArnor mentioned this pull request Sep 29, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Oct 3, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 4, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 4, 2024
Open
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
@Azzraya Azzraya mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 13, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Oct 24, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 27, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 27, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Nov 1, 2024
Open
@saiteja-madha saiteja-madha mentioned this pull request Nov 2, 2024
Closed
@AlexEKinney AlexEKinney mentioned this pull request Nov 3, 2024
Open
@Adidi1234 Adidi1234 mentioned this pull request Nov 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 5, 2024
Open
@ClearlyElevated ClearlyElevated mentioned this pull request Nov 6, 2024
Open
@jakejack13 jakejack13 mentioned this pull request Nov 7, 2024
Merged
@AlexEKinney AlexEKinney mentioned this pull request Nov 10, 2024
Open
@Azzraya Azzraya mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckohen ckohen ckohen approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees

No one assigned

Labels

packages:core packages:discord.js semver:minor

Projects

discord.js
Archived in project

Milestone

discord.js 14.16

Development

Successfully merging this pull request may close these issues.

4 participants

@almeidx @ckohen @vladfrangu @Jiralite